editor/components/formfield-type-select/index.tsx (1)

37-59: Expose a className prop on the trigger for composable styling.

Right now the trigger styling is closed over, which makes it hard for consumers to restyle. Consider threading a className prop and merging it with cn(...).

♻️ Suggested change

 export function TypeSelect({
   value,
   onValueChange,
   options = all_supported_field_type_items,
+  className,
 }: {
   value?: FormInputType;
   onValueChange: (value: FormInputType) => void;
   options?: FormFieldTypeSelectOptionItem[];
+  className?: string;
 }) {
@@
-          className="w-full justify-between"
+          className={cn("w-full justify-between", className)}

As per coding guidelines: "Use composable styling with className and merge helpers (e.g. cn(...)) in /editor/components; avoid 'closed' styling that can't be overridden" and "Expose className on outer wrappers and important slots in components to allow consumers to restyle".

editor/app/(workbench)/[org]/[proj]/(console)/(campaign)/campaigns/[campaign]/_components/settings.tsx (1)

723-782: Clean implementation of the tagging section.

The component correctly bridges the string[] form model to TagInput's {id, text} shape, handles both the function and array overloads of setTags, and conditionally enables autocomplete only when project tags exist. One minor note:

Consider filtering out autocomplete options that are already selected, so the dropdown doesn't suggest tags the user has already added. This is a UX polish item and can be deferred.

💡 Optional: filter already-selected tags from autocomplete

           render={({ field }) => {
             const tags = field.value ?? [];
+            const filtered = autocompleteOptions.filter(
+              (o) => !tags.includes(o.text)
+            );
             return (
               <FormItem>
                 <FormLabel>Invitee tags (on claim)</FormLabel>
                 <FormControl>
                   <TagInput
                     tags={tags.map((t) => ({ id: t, text: t }))}
                     setTags={(newTags) => {
                       const resolved =
                         typeof newTags === "function"
                           ? newTags(tags.map((t) => ({ id: t, text: t })))
                           : newTags;
                       field.onChange(resolved.map((t) => t.text));
                     }}
                     activeTagIndex={activeTagIndex}
                     setActiveTagIndex={setActiveTagIndex}
-                    enableAutocomplete={autocompleteOptions.length > 0}
-                    autocompleteOptions={autocompleteOptions}
+                    enableAutocomplete={filtered.length > 0}
+                    autocompleteOptions={filtered}
                     placeholder="Add tags"
                   />
                 </FormControl>

supabase/schemas/grida_west_referral.sql (1)

902-929: Consider locking down EXECUTE on the trigger function as well.

trg_auto_tag_invitee_on_claim() is SECURITY DEFINER but has no explicit REVOKE/GRANT. The schema-level default (lines 18, 21) grants ALL ON ROUTINES to anon, authenticated, service_role. While trigger functions aren't typically callable via PostgREST's RPC interface (they return trigger, not a data type), a direct SQL caller could still SELECT grida_west_referral.trg_auto_tag_invitee_on_claim() if they craft the right context. Adding the same REVOKE ALL … FROM PUBLIC pattern used for apply_customer_tags would be consistent and defensive.

Proposed diff

 CREATE TRIGGER trg_auto_tag_invitee_on_claim
 AFTER UPDATE ON grida_west_referral.invitation
 FOR EACH ROW
 EXECUTE FUNCTION grida_west_referral.trg_auto_tag_invitee_on_claim();
+
+REVOKE ALL ON FUNCTION grida_west_referral.trg_auto_tag_invitee_on_claim() FROM PUBLIC;
+REVOKE EXECUTE ON FUNCTION grida_west_referral.trg_auto_tag_invitee_on_claim() FROM anon, authenticated;

Based on learnings: "For SECURITY DEFINER functions, set a safe search_path with SET search_path = pg_catalog, public, fully qualify table references, validate tenant boundary inside the function" and "Explicitly grant permissions only to required roles; avoid accidental PUBLIC access by using REVOKE ALL FROM PUBLIC; followed by specific role grants".